Per slot disk configuration in the helm charts#9448
Conversation
| } | ||
|
|
||
| // Resolve disk_gb_per_slot from env var if set | ||
| if val := os.Getenv("RILL_PROVISIONER_DISK_GB_PER_SLOT"); val != "" { |
There was a problem hiding this comment.
We don't load environment variables directly like this. All configs are parsed and passed through from the Config struct in cli/cmd/admin/start.go
| TimeoutSeconds int `json:"timeout_seconds"` | ||
| KubeconfigPath string `json:"kubeconfig_path"` | ||
| TemplatePaths *KubernetesTemplatePaths `json:"template_paths"` | ||
| DiskGBPerSlot int `json:"disk_gb_per_slot"` |
There was a problem hiding this comment.
We should probably make the entire slot definition configurable if we go down this path, but that would be more than a provisioner change, since it affects more parts of the application.
himadrisingh
changed the title
nishantmonu51
added
the
blocker
|
|
||
| // Compute storage. If an override is provided on the project, it takes precedence over the slot-based default. | ||
| storageBytes := 40 * int64(args.Slots) * int64(datasize.GB) | ||
| storageBytes := int64(args.Slots) * int64(datasize.GB) |
There was a problem hiding this comment.
Is this missing something? Having slots to GB be 1:1 doesn't seem so useful to me (very little disk) and will be problematic for many current users
There was a problem hiding this comment.
we are trying move it to helm charts so its easily configurations
There was a problem hiding this comment.
currently we are dividing it by 1/2 in helm charts
4 participants
Make it configurable via env
Checklist: